Issue #1134 - Templates does not show RHEL and SLES icons when creati… #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinefm
requested changes
Mar 28, 2020
There was a problem hiding this comment.
I know you got a confirmation by email saying it would be fine to use the SLES logo. Could you add a note in the COPYING file saying the SLES logo is proprietary and we've gotten written permission to use it in Kimchi as a open source project and it should not be used by commercial means?
…ns when creating guests from those distros. - Add SLES icon The written consent to use SUSE logo was approved by [email protected] in February 5, 2020 According to Ciaran only this approval email is enough. We don't need to add this in our license. Signed-off-by: Renata Ravanelli <[email protected]>
alinefm
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng guests from those distros.
The written consent to use SUSE logo was approved by [email protected] in February 5, 2020
According to Ciaran only this approval email is enough. We don't need to add this in our license.
Pull Request Template
Description
Please, include a summary of the patch and why it should be accepted.
Link it to any open issue and share any other information and context you judge relevant for this PR.
Fixes # (issue)
How Has This Been Tested?
Please, describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:
make check-localto confirm it.maketo build the project and update any documentation that was added as part of this PR.make checkto confirm it)